[m-rev.] for possible post-commit objection: remove a ten year old workaround
Julien Fischer
jfischer at opturion.com
Sat May 23 13:58:42 AEST 2020
On Sat, 23 May 2020, Zoltan Somogyi wrote:
> We can back it out if this breaks anyone's workflow,
> but I don't think that is very likely.
...
> diff --git a/compiler/make.m b/compiler/make.m
> index a7d9ada29..2aaa246d7 100644
> --- a/compiler/make.m
> +++ b/compiler/make.m
> @@ -476,11 +476,7 @@ classify_target(Globals, FileName, ModuleName - TargetType) :-
>
> classify_target_2(Globals, ModuleNameStr0, Suffix, ModuleName - TargetType) :-
> ( if
> - yes(Suffix) = target_extension(Globals, ModuleTargetType),
> - % The .cs extension was used to build all C target files, but .cs is
> - % also the file name extension for a C# file. The former use is being
> - % migrated over to the .all_cs target but we still accept it for now.
> - Suffix \= ".cs"
> + yes(Suffix) = target_extension(Globals, ModuleTargetType)
> then
> ModuleNameStr = ModuleNameStr0,
> TargetType = module_target(ModuleTargetType)
No objection, but did you check that anywhere we call mmc --make foo.cs
has been updated to use mmc --make foo.all_cs?
Julien.
More information about the reviews
mailing list