[m-rev.] diff: fix mantis bug #506

Julien Fischer jfischer at opturion.com
Sun May 17 14:32:13 AEST 2020


On Sun, 17 May 2020, Zoltan Somogyi wrote:

> I have verified that extras/moose compiles with this diff.

Thanks for that.

> There is no test case, since we don't have infrastructure
> for testing the acceptability of .int3 files. (The two new
> test directories valid_make_int and invalid_make_int are
> for .int files, not .int3 files.)

We could presumably just add a multi-module program with a module
that exports such a type to tests/hard_coded; that ought to suffice
in the absence of .int3 specific test infrastructure.

> We should consider at least building, and maybe testing,
> the extras and the benchmarks as part of bootchecks.
> Opinions?

Ideally yes. In practice, especially for the extras, that's going
to be quite complicated.  I'll take a look at it.

Julien.


More information about the reviews mailing list