[m-rev.] (no subject)

[Zoltan Somogyi]

On Sat, 2 May 2020 17:36:59 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> At the moment the MR_value field will always be postive, so no.
> It's not clear what form foreign_enums for the Java backend will eventually
> take, so maybe eventually? 

OK, I modified the comment to mention that foreign_enums *could*
assign a negative value to an enum.

> That said, when are either of these operations
> ever going to be called with enum operands?

The new unsigned_lt operation's only current use
is checking shift amounts, but the old unsigned_le operation
is used by code that does e.g. lookup switches, including
on enums, so this code *could* be called on enum operands,
though only if we knew what the enum values were, which
rules out foreign_enums and hence negative enum values.

Thanks for the review, and I apologize for the empty subject line.

Zoltan.