[m-rev.] (no subject)

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri May 1 18:26:54 AEST 2020


2020-05-01 15:34 GMT+10:00 Julien Fischer<jfischer at opturion.com>:
>>              % and math_domain_error a type in the
>> +            % same module.
> 
> No. Users may want to catch such exceptions so the type needs be in a
> publicly documented part of the library.

You are right.

> My suggestions would be:
> 
>     1. in builtin.m
> 
>     2. in exception.m, alongside software_error/1

Is that an order of preference? And Peter, do you have a preference?
I don't; I am fine with either of these.
 
> (Either way I would stick with the name domain_error/1 rather than
> math_domain_error/1).

Agreed.
 
> The diff itself looks fine.

Thank you.

Zoltan.


More information about the reviews mailing list