[m-rev.] for possible objection: delete strange fallback code in deps_map.m

Peter Wang novalazy at gmail.com
Fri Mar 13 15:02:52 AEDT 2020


On Fri, 13 Mar 2020 14:51:41 +1100 (AEDT), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> The diff is trivial, I am posting this just in case someone knows
> the reason for the existence of the code that this diff deletes,
> and thinks it should be kept. Since I don't think that is likely,
> and I am working on a diff that builds on this, any objections
> will have to be post-commit. (The diff passes a bootcheck.)

Maybe this helps.

commit b2373fa0500656eb7be7f7d379297eda790f1e0e
Author: Fergus Henderson <fjh at cs.mu.oz.au>
Date:   Sat Mar 16 16:50:21 1996 +0000

    Ensure that the `.d' files generated by `mc --generate-depencies' are

    Estimated hours taken: 3

    Ensure that the `.d' files generated by `mc --generate-depencies' are
    the same as the ones produced by `mc -c'.

    compiler/modules.m:
            - Avoid any possible duplication in the list of .int and .int2 files.
            - When searching for files in generate_dependencies,
              if the `.m' file is not found, look for the `.int' file instead.
              (Necessary to ensure that the `.d' files are identical.)
            - Ensure that `.int' and `.int2' files include a `:- interface'
              declaration.  (Necessary to make the above change work.)
            - Fix a bug where I had swapped around the lists of interface and
              implementation dependencies.
            - Add some more comments.


Peter


More information about the reviews mailing list