[m-rev.] for review: support 'mercury' as a synonym for 'mmc' on all platforms

Julien Fischer jfischer at opturion.com
Tue Jun 16 16:38:16 AEST 2020


On Tue, 16 Jun 2020, Peter Wang wrote:

> On Sat, 13 Jun 2020 16:51:16 +1000 Julien Fischer <jfischer at opturion.com> wrote:
>>
>> For review by anyone.
>>
>> Branches: master, 20.06
>>
>>
>> Support 'mercury' as a synonym for 'mmc' on all platforms.
>
>> diff --git a/configure.ac b/configure.ac
>> index 63bb026..32c5918 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -5702,6 +5702,7 @@ export had_old_conf_h
>>   executable_output_files='
>>   scripts/mmc
>>   scripts/mercury.bat
>> +scripts/mercury
>
> Move that up one line.

Done.

>> diff --git a/scripts/mercury.in b/scripts/mercury.in
>> index e69de29..dd49c0f 100644
>> --- a/scripts/mercury.in
>> +++ b/scripts/mercury.in
>> @@ -0,0 +1,33 @@
>> +#! /bin/sh
>> +# @configure_input@
>> +#---------------------------------------------------------------------------#
>> +# Copyright (C) 1994-1998, 2000-2005 The University of Melbourne.
>
> Not sure if the copyright line should be replaced.

It is accurate for the contents of the file.  (Unlike
scripts/mercury.bat.in which claims to be 1994 but was only added in
2001.)

I'll go through and check these separately.

> The rest looks fine.

Thanks for that!

Julien.


More information about the reviews mailing list