[m-rev.] for review: rewrite rest of options_file.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri Jun 12 04:13:46 AEST 2020


2020-06-09 10:33 GMT+10:00 Julien Fischer<jfischer at opturion.com>:
>>>> I couldn't find any. I do think there should be some, but I am not sure
>>>> whether these should go in e.g. tests/hard_coded, or in a new subdirectory
>>>> of tests dedicated to tests of option file handling.
>>>
>>> It should be a new subdirectory; there's enough complication in
>>> hard_coded as it is.
>>
>> Agreed. However, we will need tests for both (a) correct options files,
>> and (b) incorrect options files. I think these belong in two separate
>> directories. Does anyone object to naming these "options_file"
>> and "invalid_options_file" respectively?
> 
> Not from me.

The attached updated log and diff extend the ones in my
original email to add both of these new test directories.
You may want to have a look at the new parts.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.of3a
Type: application/octet-stream
Size: 3721 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20200612/b80c227b/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.of3a
Type: application/octet-stream
Size: 110433 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20200612/b80c227b/attachment-0003.obj>


More information about the reviews mailing list