[m-rev.] for review: do not allow the use of x86_64-pc-msys

Julien Fischer jfischer at opturion.com
Thu Jan 23 13:57:01 AEDT 2020


For review by anyone.

I've been bitten by this one too many times.

------------------------------------

Do not allow the use of x86_64-pc-msys.

configure.ac:
     Stop and report an error if this script is run on the x86_64-pc-msys
     architecture; that will go badly wrong as the configure script currently does
     not handle it correctly.

Julien.

diff --git a/configure.ac b/configure.ac
index e9fa577..8a68912 100644
--- a/configure.ac
+++ b/configure.ac
@@ -257,6 +257,20 @@ fi

  #-----------------------------------------------------------------------------#

+# Ensure that the user does not try to build MSYS executables; we do not
+# (currently) support that.
+
+case "$host" in x86_64-pc-msys)
+   AC_MSG_ERROR(
+[
+***** The x86_64-pc-msys architecture is not supported.
+***** You probably meant to use one of: x86_64-pc-mingw32, x86_64-pc_mingw64.])
+   exit 1
+   ;;
+esac
+
+#-----------------------------------------------------------------------------#
+
  # Using `cygpath -m' gives a path that works under both Cygwin and native
  # Windows, without causing quoting problems in shell scripts.
  # (`cygpath -m' converts the path to Windows format, with '/' as the directory


More information about the reviews mailing list