[m-rev.] for pre-commit review: workaround Mantis bug #453

Peter Wang novalazy at gmail.com
Mon Jan 20 15:27:31 AEDT 2020


On Mon, 20 Jan 2020 13:33:45 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> >
> > Ok.
> >
> > I think instead of your original patch, we should be setting
> >    mercury_cv_asm_labels=no
> >    mercury_cv_gcc_labels=no
> >
> > as in the attached patch.
> 
> Yes, that's a better approach.  Can you please go ahead and commit
> that one.

Done.

I thought of another workaround that might work: to use non-PIC in
shared libraries. But I won't be pursuing it.

No objection to using hlc as the default grade.

Peter


More information about the reviews mailing list