[m-rev.] for pre-commit review: workaround Mantis bug #453
Julien Fischer
jfischer at opturion.com
Mon Jan 20 14:05:52 AEDT 2020
On Mon, 20 Jan 2020, Julien Fischer wrote:
> On Mon, 20 Jan 2020, Peter Wang wrote:
>
>> On Mon, 20 Jan 2020 03:15:08 +1100 (AEDT), Julien Fischer
>> <jfischer at opturion.com> wrote:
>
>>> I propose that we simply use 'reg' as the default LLDS base grade on the
>>> affected systems. Furthermore, we make 'hlc' the default base grade
>>> on systems where the default LLDS base grade is 'reg'.
>>>
>>> Given that this only affects i*86 systems, I don't think it's worth
>>> spending much further effort on it, at least for the purposes of the
>>> 20.01 release.
>>
>> Ok.
>>
>> I think instead of your original patch, we should be setting
>> mercury_cv_asm_labels=no
>> mercury_cv_gcc_labels=no
>>
>> as in the attached patch.
>
> Yes, that's a better approach. Can you please go ahead and commit
> that one.
I assume no-one has any objections to the second part of what a I
proposed above, namely forcing the default base grade to be 'hlc' when
the llds base grade is 'reg'.
Julien.
More information about the reviews
mailing list