[m-rev.] for review: rationalise hash functions across the standard library

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Feb 15 11:11:21 AEDT 2020



On Fri, 14 Feb 2020 20:27:39 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> You can go ahead; I won't be touching hash_table code for a few
> weeks at least.

Done. The diff is attached. It is for review by Peter, with special attention
to the new XXXs.

Peter, could you tell me why version_hash_table uses user-defined equality?
The change was done by pbone, but I hope you may have discussed the
issue with him. The discussion on m-rev in May 2013, when the user defined
equality was added, says nothing about *why* it was added, except one
possibly-relevant vague reference to "MC needing it", and I see nothing
relevant in that time frame in m-dev.

Zoltan.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ht
Type: application/octet-stream
Size: 1084 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20200215/6e3d77f1/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ht
Type: application/octet-stream
Size: 45054 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20200215/6e3d77f1/attachment-0003.obj>


More information about the reviews mailing list