[m-rev.] for review: announce the fix for bug #496

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Feb 9 16:48:54 AEDT 2020


2020-02-09 16:41 GMT+11:00 Julien Fischer<jfischer at opturion.com>:
> +This is a bug-fix release.
> +
> +* [Mantis bug #496]. The compiler now emits a reminder about the limitation
> +  of common subexpression elimination in the presence of uniqueness when
> +  this is a possible cause of determinsim errors.

Determinism is spelt wrong. A full spellcheck would be in order.

> +  As of version 20.01, common subexpression elimination does not transform
> +
> +         (
> +             X = f(A1, ..., An),
> +             goal A
> +         ;
> +             X = f(B1, ..., Bn),
> +             goal B
> +         )
> +
> +  into
> +
> +         X = f(X1, ..., Xn),
> +         (
> +             A1 = X1, ..., An = Xn,
> +             goal A
> +         ;
> +             B1 = X1, ..., Bn = Xn,
> +             goal B
> +         )
> +
> +  when the insts of some of `X`'s arguments are at least partially unique.

Why is X quoted? It interferes with the apostrophe, and so subtracts
rather than adds clarity.

Other than that, the diff is fine.

Zoltan.


More information about the reviews mailing list