[m-rev.] for review: may_ignore_without_warning

Peter Wang novalazy at gmail.com
Wed Aug 19 13:46:56 AEST 2020


On Wed, 19 Aug 2020 06:14:39 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 2020-08-18 15:54 GMT+10:00 "Peter Wang" <novalazy at gmail.com>:
> > On Tue, 18 Aug 2020 14:35:43 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> >> Does anyone have a better proposal for the name of the new attribute?
> > 
> > Maybe disable_warning_if_ignored?
> 
> Good idea. I followed all your suggestions, which resulted
> in the first attached diff, which is for post-commit review.
> There is a test case, but it is in the next diff (also attached),
> which I will commit after an rotd is built with the first one.
> 
> Zoltan.


> Start using --disable-warning-if-ignored.

disable_warning_if_ignored

> 
> configure.ac:
>     Require the installed compiler to support the new attribute.
> 
> compiler/ctgc.selector.m:
> deep_profiler/query.m:
>     Use the attribute to shut up warnings in non-C grades.

Otherwise, it looks fine.

Peter


More information about the reviews mailing list