[m-rev.] for review: filename extensions

Julien Fischer jfischer at opturion.com
Sat Aug 15 00:28:52 AEST 2020


On Sat, 15 Aug 2020, Zoltan Somogyi wrote:

>
>> Intestingly enough this change did break something, while the C# grade
>> bootchecks, library installation in the C# grade now causes the compiler
>> to abort:
>>
>>     Making mer_std.dll
>>
>>     ...
>>
>>     Uncaught Mercury exception:
>>     Software Error: predicate `parse_tree.file_names.choose_file_name'/9:
>>     Unexpected: unknown extension `int'
>>     Stack dump not available in this grade.
>>     gmake[1]: *** [libmer_std.install] Error 1
>>     gmake[1]: Leaving directory
>
> I think the attached diff should fix that. I just started a C# bootcheck of it;
> you may wish to test a C# install.

No, it's now:

     Uncaught Mercury exception:
     Software Error: predicate `parse_tree.file_names.choose_file_name'/9:
     Unexpected: unknown extension `ints'
     Stack dump not available in this grade.
     gmake[1]: *** [libmer_std.install] Error 1

>
>>> The failures were news to me, since I never use subdirs of either flavor
>>> with C grades. Does anyone? Is it even supposed to work?
>>
>> --use-grade-subdirs is not supposed to work with mmake (only mmc --make).
>
> Should we add an error message pointing out this fact if --use-grade-subdirs
> is specified without --make or --invoked-by-mmc-make?
>
>> --use-subdirs is supposed to work with mmake (if the user's guide is to
>> be believed).
>
> Has anyone tested that recently?

I guess not.

> It would be nice if we had a continuous record of the success or failure
> of a test case for this functionality ...

We should be able to set up one of the configurations on the test server
to bootcheck with --use-subdirs enabled.

Julien.


More information about the reviews mailing list