[m-rev.] for review: filename extensions

Julien Fischer jfischer at opturion.com
Fri Aug 14 17:51:51 AEST 2020



On Thu, 13 Aug 2020, Zoltan Somogyi wrote:

> For review by anyone. I have bootchecked this in C# and Java grades
> as well as C grades.

For future changes building on this, I suspect where we may see any
breakage is in Windows vs. non-Windows systems.

...

> Make filename extensions a separate type, ...
> 
> ... to allow later changes to its definition.

...

> scripts/c2init.in:
> scripts/canonical_grade.in:
> scripts/mdprof.in:
> scripts/mercury.in:
> scripts/mercury_update_interface.in:
> scripts/mgnuc.in:
> scripts/mkfifo_using_mknod.in:
> scripts/ml.in:
> scripts/mmake.in:
> scripts/mmc.in:
> scripts/mprof.in:
> scripts/prepare_install_dir.in:

I don't think this list of files should be here; the diff doesn't contain any
changes for these files.

The diff looks fine otherwise.

Julien.


More information about the reviews mailing list