[m-rev.] for review: breakpoints on line numbers

[Zoltan Somogyi]

2020-08-08 04:04 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
> (In theory, INT_MAX may not be big enough since Mercury doesn't actually
> impose any limit on how large the line number in a #line directive can
> be; C does impose such a limit -- for C99 it is 2147483647.)

Given that the only consequence of anyone using a line number above INT_MAX
will be a misleading aside in an error message, I am willing to commit this
without imposing a C99-like limit on our equivalents of #line directives :-)
I did add a comment about this issue.

>> Improve an mdb error message.
>> > trace/mercury_trace_spy.c:
>>     When the user wants to put a breakpoint on a line in a file,
>>     but there is no event exactly on the given line number,
>>     mdb used to tell the user just that fact. This diff makes
>>     mdb more helpful, by printing the nearest line numbers before
>>     and after the given line number that *do* have events on which
>>     breakpoints can be put.
>>
>>     The mismatch can come for several reasons, with the most common
>>     probably being that textuall, a switch arm for e.g X being f
> 
> s/textuall/textual/

I changed it to "textually" instead.

Thanks for both reviews.

Zoltan.