[m-rev.] for review: build grade_lib by default

Julien Fischer jfischer at opturion.com
Mon Apr 13 14:57:22 AEST 2020


On Mon, 13 Apr 2020, Zoltan Somogyi wrote:

> For review by anyone.

> diff --git a/grade_lib/Mmakefile b/grade_lib/Mmakefile
> index ad8019627..e08fc0cb7 100644
> --- a/grade_lib/Mmakefile
> +++ b/grade_lib/Mmakefile

...

> @@ -20,19 +20,29 @@ Mmake.grade_lib.params:
>  # by `mmc --make'.
>  -include Mercury.options
> 
> --include ../Mmake.params
> -
>  MCFLAGS += --flags GRADE_LIB_FLAGS $(CONFIG_OVERRIDE)
> 
> +# The main targets are the exeutables of the utilities that use and test
> +# the grade library. The grade "library" itself is not a target, because

s/exeutables/executables/

> +# it is intended to be used *only* by these utilities (and perhaps later,
> +# similar utilities) and by the compiler itself. The utilities use the
> +# modules of the library in this directory, while we intend to give
> +# the compiler access by copying the source files of the grade library,
> +# in read-only form, to the compiler directory, just the way we copy
> +# the modules of the mdbcomp library to the slice and deep_profiler
> +# directories. The source distribution will get those read-only copies
> +# as well. This arrangement has the advantage that the grade in which
> +# the compiler is compiled is independent of the grade of the utilities.

That looks fine otherwise.

Julien.


More information about the reviews mailing list