[m-rev.] for review: fix mmake rules for os,cs,css,javas

[Zoltan Somogyi]

On Sat, 11 Apr 2020 18:44:38 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:

> On Sat, 11 Apr 2020, Zoltan Somogyi wrote:
> 
> > For review by anyone.
> >
> > This has been bootchecked in hlc.gc, asm_fast.gc,
> > csharp and java.
> 
> Another relevant test here would be to check that the source
> distribution builds.

Good idea, but it has been a *very* long time since I have done that.
Do you mean "mmake tar" at the top level, or something else?

> > Fix mmakefile rules for os,cs,css,javas.
> >
> > The main objective of this change is to get bootchecks in the csharp
> > and java grades to actually build the slice, profiler, deep_profiler
> > and mfilterjavac directories, which (due to the bug this diff fixes)
> > they weren't doing before.
> > 
> > However, since one side effect of this change is to eliminate
> > one source of annoying warnings from mmake about references to undefined
> > variables, a subsidiary objective s to eliminate other sources of such
> 
> s/s/is/

Done.

> > warnings as well, which mostly come from the rules for making tags files.
> 
> ...
> 
> > diff --git a/browser/Mmakefile b/browser/Mmakefile
> > index 3acab9240..c56020002 100644
> > --- a/browser/Mmakefile
> > +++ b/browser/Mmakefile
> > @@ -1,5 +1,5 @@
> >  #-----------------------------------------------------------------------------#
> > -# vim: ts=8 sw=8 noexpandtab
> > +# vim: ts=8 sw=8 noexpandtab ft=make
> >  #-----------------------------------------------------------------------------#
> >  # Copyright (C) 1998-2007, 2009-2010, 2012 The University of Melbourne.
> >  # This file may only be copied under the terms of the GNU General
> > @@ -186,19 +186,32 @@ int3s:	$(INT3S_TARGETS)
> >
> >  #-----------------------------------------------------------------------------#
> > 
> > +# We need the shenanigans with .browser_tags to avoid situations in which
> > +# "mmake tags" in this directory does nothing even in the absence of a tags
> > +# file in this directory, because mmake uses VPATH to find ../library/tags
> > +# and believes it to be the tags file we are asking for.
> > +#
> > +# We give files in mdbcmp before the files in this directory because
> 
> s/mdbcmp/mdbcomp/

Done.

> > +# we want references to entiies defined in the modules copied from the
> 
> s/entiies/entities/

Done, both here and elsewhere.

> The diff looks fine otherwise.

Thanks for the review.

Zoltan.