[m-rev.] for review: delete the hl grade component

Peter Wang novalazy at gmail.com
Sat Apr 11 13:25:10 AEST 2020

On Sat, 11 Apr 2020 10:02:02 +1000 (AEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> I also have a question. This diff deletes every occurrence of
> the C macro MR_HIGHLEVEL_DATA, since it is now unnecessary,
> but a bunch of occurrences of that string remain in C# code,
> almost all in #ifdefs in library/rtti_implementation.m. The
> #else parts of those #ifdefs seem to me to be relics of the
> .NET backend, when it tried to access low-level-data RTTI.
> Since compile_target_code.m *always* defined MR_HIGHLEVEL_DATA
> for C#, I think the non-MR_HIGHLEVEL_DATA sides of those
> #ifdefs are dead code, but I am not 100% sure.

You are right.

> Does anyone
> have any reason to believe that these apparently dead pieces
> of code are in fact needed? And if not, is there any reason why
> we need to continue defining MR_HIGHLEVEL_DATA for C#? 

I don't think it's necessary.


More information about the reviews mailing list