[m-rev.] for post-commit review: det_remove*, rev_sorted_list_to_set

Peter Wang novalazy at gmail.com
Mon Sep 9 15:31:21 AEST 2019


On Mon, 9 Sep 2019 14:42:41 +1000, Peter Wang <novalazy at gmail.com> wrote:
> 
> To me, the predicates/functions with "sorted_list_to_" in their names
> already indicate that it is the caller's responsibility to pass sorted
> lists as input. The simplest solution is to leave them as unchecked, but
> make the documentation more explicit.

map also contains these predicates/functions that assume sorted input:

    map.delete_sorted_list
    map.select_sorted_list - requires no duplicates
    map.select_unselect_sorted_list  - requires no duplicates

Peter


More information about the reviews mailing list