[m-rev.] for review: add a "suggested replacement" arg to obsolete pragmas

[Peter Wang]

On Sun, 08 Sep 2019 22:53:56 +1000 (AEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by anyone.
> 
> The main change in {Log,DIFF}.obs adds the optional new argument
> to obsolete pragmas.

That looks fine.

> Once that diff reaches the rotds and is installed
> on each of our systems, the second diff can be committed.

I disagree with deprecating *.from_list, *.from_sorted_list list.

Preferences aside, the naming patterns

    <module>.to_<type>
    <module>.from_<type>

and related

    <module>.cast_to_<type>
    <module>.cast_from_<type>

are widely used in the standard library compared to <type>_from_<type>
and <type>_to_<type>.

Peter


> +    % For each pred_id in the list, add the given markers to the
> +    % list of markers in the corresponding pred_info.
> +    %
> +:- pred mark_pred_ids_as_obsolete(list(sym_name_and_arity)::in,
> +    pred_status::in, list(pred_id)::in, bool::in, bool::out,
> +    pred_table::in, pred_table::out) is det.

The comment should not refer to markers.

> diff --git a/doc/reference_manual.texi b/doc/reference_manual.texi
> index 041c6eb..8f6351a 100644
> --- a/doc/reference_manual.texi
> +++ b/doc/reference_manual.texi
> @@ -10779,17 +10779,21 @@ user-requested type specializations are ignored.
>  @node Obsolescence
>  @section Obsolescence
>  
> -A declaration of the form
> +Declaration of the forms

Declarations