[m-rev.] for post-commit review: det_remove*, rev_sorted_list_to_set

[Julien Fischer]

Hi Zoltan,

On Sun, 8 Sep 2019, Zoltan Somogyi wrote:

> For post-commit review by anyone.

...

> Reduce differences between library/set*.m.
> 
> library/set*.m:
>     Add det_remove and det_remove_list predicates to the set modules
>     that did not yet have them.
>
>     Add rev_sorted_list_to_set in both predicate and function form
>     to the set modules that did not yet have such functionality.
>     Note: some modules had such a function, but not predicate.
>     This diff leaves those modules alone.
>
>     Document that the input to sorted_list_to_set predicates and functions
>     should not have duplicates, unless the predicate in question detects
>     and removes duplicates. The different set modules are inconsistent
>     in this regard.

Perhaps we ought to give the version that doesn't check a different name,
e.g. unchecked_sorted_list_to_set?

>
>     Use consistent variable names.
> 
> NEWS:
>     Announce the new predicates and functions.

That seems fine.

One note about this; although they are more specialised, diet.m,
fat_sparse_bitset, sparse_bitset.m and tree_bitset.m would probably
benefit from following the same predicate ordering (where possible) as
the generic set implementations.

Julien.