[m-rev.] for review: fix a bug in the C# implementation of array.shrink/3

Peter Wang novalazy at gmail.com
Thu Sep 5 16:50:23 AEST 2019


On Thu, 5 Sep 2019 16:28:33 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> 
> For review by Peter.
> 
> -------------------
> 
> Fix a bug in the C# implementation of array.shrink/3.
> 
> library/array.m:
>     Workaround the fact that C#'s 'is' operator has some fairly surprising
>     behaviour with arrays of integer types.

I'll take your word for it!

> 
> tests/hard_coded/array_primitives.{m,exp}:
> tests/hard_coded/array_shrinks.{m,exp}:
>     Improve the coverage of these tests.

That looks fine.

Peter


More information about the reviews mailing list