[m-rev.] for post-commit review: reorder the interface of io.m

Peter Wang novalazy at gmail.com
Wed Oct 30 12:43:51 AEDT 2019


On Wed, 30 Oct 2019 12:13:51 +1100 (AEDT), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 
> On Wed, 30 Oct 2019 12:01:44 +1100, Peter Wang <novalazy at gmail.com> wrote:
> 
> > format doesn't quite belong in the "Writing out several values" section.
> > Perhaps add a "Formatted output" section before that section, even if it
> > contains just the two predicates.
> 
> Agreed, but I have question: should write_many, which also uses poly_types,
> go in that section as well? I can see arguments both for and against.
> 

No, because it doesn't take a format string. It's just a convenience to
make several primitive io.write_* calls with a single call, which fits
neatly into the theme of the "Writing out several values" section.

(I don't think I've ever seen write_many used before.)

Peter


More information about the reviews mailing list