[m-rev.] for review: more specific errors when file sizes exceed maximum buffer sizes
Julien Fischer
jfischer at opturion.com
Mon Oct 28 13:50:51 AEDT 2019
Hi Peter,
On Mon, 28 Oct 2019, Peter Wang wrote:
> On Mon, 28 Oct 2019 13:33:25 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>>
>>> On second thought, why throw an exception instead of returning an error?
>>
>> Doing so would break the existing interface; there isn't currently a
>> slot to return such an error.
>
> I think io.error is fine.
You're right. I thought io.error was the error code rather than a
string.
Julien.
More information about the reviews
mailing list