[m-rev.] for pre/post-commit review: add all pragmas to HLDS at once

Julien Fischer jfischer at opturion.com
Tue Nov 26 17:28:22 AEDT 2019


On Tue, 26 Nov 2019, Zoltan Somogyi wrote:

> On Tue, 26 Nov 2019 15:42:45 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>> I would suggest committing it now / early this evening so it ends up in
>> today's ROTD build.
>
> Any particular reason?

You did say it was for post-commit review, and since there have been no
other changes today ...

> Or have you reviewed it in the five minutes between emails?

No, but I have reviewed it on the train trip home ;-)  It looks fine,
you can go ahead and commit.

Julien.


More information about the reviews mailing list