[m-rev.] for post-commit review: setting up module_and_imports
zoltan.somogyi at runbox.com
Tue May 7 20:30:06 AEST 2019
On Tue, 7 May 2019 07:10:46 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
> I've run this on all my usual test cases and have not encountered any
Thank you for that, and for the review.
> > @@ -2152,10 +2231,16 @@ get_pragma_foreign_code(Globals, Pragma, !Info) :-
> > globals.get_backend_foreign_languages(Globals, BackendLangs),
> > globals.get_target(Globals, Target),
> > - % The code here should match the way that mlds_to_gcc.m decides whether
> > - % or not to call mlds_to_c.m.
> > - % XXX FIXME mlds_to_gcc.m no longer exists.
> > (
> > + % We do NOT count foreign_decls here. We only link in a foreign object
> > + % file if mlds_to_gcc called mlds_to_c.m to generate it, which it
> > + % will only do if there is some foreign_code, not just foreign_decls.
> > + % Counting foreign_decls here causes problems with intermodule
> > + % optimization.
> Something needs updating here (the comment certainly), but I'm not quite
> sure what. Was there an issue with foreign_decls and intermodule
> optimization independent of the GCC backend?
I know of no such issue. Fergus was the only one who ever worked on the gcc
I did not add that comment; I merely moved it.
You are right, it is obsolete. There is no point in updating it, because I intend
to delete the entire predicate soon; this diff added its intended replacement.
More information about the reviews