[m-rev.] a question about accessibility rules and error messages

[Julien Fischer]

On Fri, 29 Mar 2019, Zoltan Somogyi wrote:

>
>
> On Wed, 20 Mar 2019 10:56:25 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
>>> I have a slight preference for the first fix, but could easily live with the second.
>>
>> I prefer the first fix.
>
> The attached diff implements this fix. Will someone volunteer to review it?

The diff looks fine; minor fix to the log message below.

> Tighten module accessibility rules.

...

> compiler/check_raw_comp_unit.m:
> compiler/comp_unit_interface.m:
> compiler/deps_map.m:
> compiler/equiv_type.m:
> compiler/get_dependencies.m:
> compiler/make.module_dep_file.m:
> compiler/make_hlds_separate_items.m:
> compiler/module_imports.m:
> compiler/module_qual.collect_mq_info.m:
> compiler/module_qual.m:
> compiler/module_qual.qualify_items.m:
> compiler/parse_tree_out.m:
> compiler/prog_item_stats.m:
> compiler/recompilation.check.m:
> compiler/split_parse_tree_src.m:
>     Conform to the changes above.
> 
> tests/invalid/missing_parent_import.err_exp:
>     Expect an additional error messages we now generate.

s/messages/message/

> tests/invalid/sub_c.err_exp:
> tests/invalid/test_nested.err_exp:
>     Expect the more specific error messages we now generate.

Julien.