[m-rev.] for review: improve deconstruction (and printing) of foreign types in C# and Java grades
jfischer at opturion.com
Wed Mar 13 16:53:49 AEDT 2019
On Wed, 13 Mar 2019, Zoltan Somogyi wrote:
> On Wed, 13 Mar 2019 05:30:08 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
>> +get_target_lang_rep(_) = "some_foreign_value".
> This clause should be used only in erlang grades, in which it should be
> possible to do better, but I guess it does not matter much.
Yes, we could do better in Erlang, although its RTTI implementation
is in library/erlang_rtti_implementation.m and I don't think it
even looks at this one.
(Also, I'm working with code that uses the Java backend at the moment,
so making it work with Erlang isn't a priority ;-) )
> The rest of the diff is fine.
Thanks for that.
More information about the reviews