[m-rev.] for review: edit_seq for --warn-inconsistent-pred-order

Julien Fischer jfischer at opturion.com
Thu Jun 27 02:15:52 AEST 2019


On Wed, 26 Jun 2019, Zoltan Somogyi wrote:

> For review by anyone.
>
> This should fix one test case failure for C# (and probably Java), because
> io.call_system_code does not handle redirection.
>
> A question: is it ok for the warning to list long sequences of unchanged lines,
> or should I postprocess the output to elide them.

You should probably send the diff first ;-)

> A related question: does anyone insist on the current organization of io.m,
> where foreign_procs are clustered by language? I would like to reorder its
> contents to put all the foreign_procs for a predicate next to each other.
> That should make it easier to catch problems like this where the different
> foreign_procs for the same predicate do slightly different things.

I don't have any objections to doing that.

Julien.


More information about the reviews mailing list