[m-rev.] for review: dump either clauses or procs, not both

Julien Fischer jfischer at opturion.com
Mon Jul 22 23:07:17 AEST 2019


On Sun, 21 Jul 2019, Zoltan Somogyi wrote:

> Does anyone object to this change, whose effect is shown on the attached dump?

I don't.

> Dump either a predicate's clauses or its procedures, but not both.
> 
> compiler/hlds_out_pred.m:
>     As above. Before the clauses have been copied to the procedures,
>     dumping the procedures isn't very useful, while after the copy,
>     the clauses are obsolete, and their code can be too easily mistaken for
>     the code of the procedures.
>
>     Don't export a predicate that isn't used elsewhere.
>
>     Avoid redundant lookups.

That's fine.

Julien.


More information about the reviews mailing list