[m-rev.] for review: reading multibyte integers from binary file streams
jfischer at opturion.com
Thu Jan 31 13:13:54 AEDT 2019
On Sun, 27 Jan 2019, Zoltan Somogyi wrote:
> On Sun, 20 Jan 2019 04:36:28 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
>> I'm going to go ahead and commit this one now; I'll deal with any further
>> review comments separately.
> Sorry for the late review. I am concerned that your code may try to
> reverse the bytes even inside uint8s, which would fail because there is
> no function to perform that noop. Can you have a look at *my* review,
> which takes the form of the attached diff?
Were you intending to apply this diff yourself, or did you want me
to do it?
More information about the reviews