[m-rev.] for review: reading multibyte integers from binary file streams

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Jan 27 00:41:49 AEDT 2019

On Sun, 20 Jan 2019 04:36:28 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
> I'm going to go ahead and commit this one now; I'll deal with any further
> review comments separately.

Sorry for the late review. I am concerned that your code may try to
reverse the bytes even inside uint8s, which would fail because there is
no function to perform that noop. Can you have a look at *my* review,
which takes the form of the attached diff?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.io
Type: application/octet-stream
Size: 5465 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20190127/b8be0ace/attachment-0001.obj>

More information about the reviews mailing list