[m-rev.] for review: faster merging of varsets

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jan 23 12:49:58 AEDT 2019



On Mon, 14 Jan 2019 06:38:53 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
> > If someone would undertake to run tuning benchmarks for me,
> > I would write the required benchmarking code.
> 
> I'm happy to run them for you.

Thank you. The benchmark program is attached, as are the updated log file
and diff.

BTW, on my machine, the benchmark time went from about 920ms to about 170ms.

> I would say add a "faster alternative implementation" since the existing
> one is still present.

The updated log file mentions that.

Thanks for the review, and for the benchmarking.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.varset
Type: application/octet-stream
Size: 1921 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20190123/e5ea34bf/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.varset
Type: application/octet-stream
Size: 24996 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20190123/e5ea34bf/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: varset_test.m
Type: application/octet-stream
Size: 2343 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20190123/e5ea34bf/attachment-0005.obj>


More information about the reviews mailing list