[m-rev.] for review: Add Dockerfile to containerise mmc.
jfischer at opturion.com
Wed Jan 2 22:59:37 AEDT 2019
Hi Zoltan and Sebastian,
On Wed, 2 Jan 2019, Zoltan Somogyi wrote:
> On Thu, 27 Dec 2018 16:26:26 +0000, Sebastian Godelet <sebastian.godelet at outlook.com> wrote:
>> Add Dockerfile to containerise mmc.
> I know enough about docker to know that this is a good idea,
It is a good idea.
> but not enough to review this diff, or your updated pull request.
> Does anyone on the Mercury core team know docker well enough to do a review?
By annoying necessity I probably do :-( I started reviewing this and
got about as far as installing docker on my home machine. I have some
minor comments about the documentation, but they're probably easier to
handle myself post-commit. The diff raises a couple of bigger issues,
such as how the runtime and standard library .so files are distribute,
but that's a separate matter.
I'll go ahead and approve the pull request.
More information about the reviews