[m-rev.] for review: don't emit msgs when creating interface files

Peter Wang novalazy at gmail.com
Mon Aug 26 15:10:45 AEST 2019


On Mon, 26 Aug 2019 14:48:39 +1000 (AEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 
> On Sun, 25 Aug 2019 19:41:15 +1000 (AEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> > The diff is mostly straightforward, but I am seeking people's opinions
> > on three things.
> > 
> > First, does anyone object to delaying messages about unexpected items
> > in interfaces, or the absence of items in interfaces, until code generation time?
> > 
> > Second, does this change warrant an entry in NEWS?

I don't think it warrants any NEWS, but it wouldn't hurt either.

> > 
> > Third, would anyone object to a later change that puts all checking
> > of whether an item belongs in a given section of a given file into one place,
> > parse_module.m?
> 
> In the absence of any objections until then, I intend to commit this diff
> tomorrow morning.

No objections from me.

Peter


More information about the reviews mailing list