[m-rev.] diff: avoid clutter in generated Java code
Zoltan Somogyi
zoltan.somogyi at runbox.com
Fri Aug 2 16:50:08 AEST 2019
On Fri, 2 Aug 2019 13:30:36 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> + ( if map.is_empty(ScalarCellGroupMap) then
> + true
> + else
> + % Scalar common data must appear after the previous data definitions,
> + % and the vector common data after that.
> + io.write_string("\n// Scalar common data\n", !IO),
> + output_scalar_common_data_for_java(Info, Indent + 1,
> + ScalarCellGroupMap, !IO)
> + ),
I would lift that comment out of the if-then-else, since its scope
includes the following block of code.
Zoltan.
More information about the reviews
mailing list