[m-rev.] for post-commit review: construct initial module_and_imports directly

Julien Fischer jfischer at opturion.com
Tue Apr 23 01:18:31 AEST 2019



On Mon, 22 Apr 2019, Zoltan Somogyi wrote:

> The cause of the abort was this:
>
> SortedOldIntItems:- type g12.seq.seq(T).
> :- pragma foreign_type(c, g12.seq.seq(T), "MR_ArrayPtr", [can_pass_as_mercury_type]).
> :- pragma foreign_import_module("C", (g12.seq)).
> :- pragma foreign_import_module("C", (g12.seq)).
> SortedNewIntItems:- type g12.seq.seq(T).
> :- pragma foreign_type(c, g12.seq.seq(T), "MR_ArrayPtr", [can_pass_as_mercury_type]).
> :- pragma foreign_import_module("C", (g12.seq)).
>
> Having the old code generate the same item twice is unfortunately
> not surprising; that code is so opaque it is hard to see such things in it.
>
> I have committed a fix to the sanity check. Please try it out.

I have tried the latest version of the compiler out on my usual
set of test programs and have not encountered any issues.

Julien.


More information about the reviews mailing list