[m-rev.] for review: add --warn-suspicious-foreign-code

Julien Fischer jfischer at opturion.com
Sat Sep 29 00:34:44 AEST 2018


On Sat, 29 Sep 2018, Zoltan Somogyi wrote:

> On Fri, 28 Sep 2018 12:44:47 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
>> diff --git a/doc/user_guide.texi b/doc/user_guide.texi
>> index a687884..0eb6880 100644
>> --- a/doc/user_guide.texi
>> +++ b/doc/user_guide.texi
>> @@ -6832,6 +6832,14 @@ is limited some warnings reported by this option may be spurious and
>>   some actual errors may not be detected at all.
>>
>>   @sp 1
>> + at item --warn-suspicious-foreign-code
>> + at findex --warn-suspicious-forign-code
>> +Warn about possible errors in the bodies of foreign code pragmas.
>> +Note that since the compiler's ability to parse foreign language code
>> +is limited some warnings reported by this option may be spurious and
>> +some actual errors may not be detected at all.
>
> I would add a comma after "limited", and after "spurious".

Done.

(I've also fixed the spelling of foreign above too.)

> Otherwise, the diff is fine.

Thanks for that.  I intend to enable this option by default for the
Mercury compiler after everyone has updated their compilers.

Julien.


More information about the reviews mailing list