[m-rev.] for review: warn about unsigned comparisons against zero that are tautologies

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Oct 21 23:53:55 AEDT 2018



On Sun, 21 Oct 2018 03:26:15 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
 
> On Sun, 21 Oct 2018, Peter Wang wrote:
> 
> > On Sat, 20 Oct 2018 09:45:28 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
> >>>
> >>> Note that I think Peter is also working on this module, so one of you
> >>> will probably get a conflict :-(
> >>
> >> Since I've primarily added code I hope not!  In any case, Peter can you
> >> let me know if this will cause problems for you.  If so, I will hold
> >> of pushing it.
> >
> > Don't worry, I haven't started any work on the module.
> 
> What are you planning to do to it?

Since Peter hasn't replied: fix the gcc warning about tautological
comparisons. Your diff was about warning the user about tautological
comparisons *they* write; Peter wants to fix the tautological comparisons
that the *compiler* has generated since my last change to simplify_goal_call.m.
See our email exchange two days ago.

Zoltan.


More information about the reviews mailing list