[m-rev.] for review: putback of 8-bit values to binary input streams

Julien Fischer jfischer at opturion.com
Fri Oct 5 16:36:11 AEST 2018



On Fri, 5 Oct 2018, Peter Wang wrote:

> On Fri, 5 Oct 2018 06:29:15 +0000 (UTC), Julien Fischer <jfischer at opturion.com> wrote:
>>>> diff --git a/library/io.m b/library/io.m
>>>> index 20af25a..b3356ff 100644
>>>> --- a/library/io.m
>>>> +++ b/library/io.m
>>>> @@ -1014,6 +1014,20 @@
>>>>   :- pred putback_byte(io.binary_input_stream::in, int::in, io::di, io::uo)
>>>>       is det.
>>>
>>> The description for putback_byte itself does not describe the behaviour
>>> for out-of-range values.
>>
>> It's supposed to be the bottom 8 bits of the int, which is what we say
>> elsewhere for predicates that deal with "bytes".  I've added sentence
>> to that end.
>
> Thanks.

Incidentally, now that we have uint8 and int8 we should (very) gradually
start deprecating bytes being the bottom 8 bits of an int.

Julien.


More information about the reviews mailing list