[m-rev.] for review: bulk unify and compare

[Julien Fischer]

On Wed, 3 Oct 2018, Julien Fischer wrote:

> On Wed, 3 Oct 2018, Julien Fischer wrote:
>>
>>  On Wed, 3 Oct 2018, Zoltan Somogyi wrote:
>>
>>>   I just committed the diff with the changes that the reviews asked for.
>>>   It has clean bootchecks in hlc.gc and asm_fast.gc, but there were
>>>   *lots* of differences from tools/make_java_csharp_diff; too many
>>>   to visually check them all. The ones I did check were all trivial
>>>   changes
>>>   in variable names, a consequence of the fact that unify_proc.m now
>>>   allocates variables in a different order than it used to, which changes
>>>   HLDS variable numbers (which get included in Java and C# variable
>>>   names).
>>>
>>>   Julien, can I ask you to try out the updated compiler in the Java and C#
>>>   grades?
>>
>>  I've successfully bootchecked the updated compiler in the Java grade;
>>  the C# bootcheck is running now.
>
> The C# grade also succesfully bootchecked.

It has however broken the Erlang grade:


    ...
    Making Mercury/ints/thread.mvar.int
    Making Mercury/ints/thread.semaphore.int
    Making Mercury/opts/array.opt
    Uncaught Mercury exception:
    Software Error: function
    `check_hlds.unify_proc.compute_maybe_packable_args_locn'/1: Unexpected:
    wrong tag for a general du functor with args
    Stack dump not available in this grade.
    ** Error making `Mercury/opts/array.opt'.

Julien.