[m-rev.] for review: pack sub-word-sized integers and dummies

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat May 5 21:21:34 AEST 2018



On Sun, 22 Apr 2018 06:05:33 +1000 (AEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> > Looks fine otherwise.
> 
> Thanks for the review.

The new testing I added for this review revealed a couple of problems,
which I have now fixed, so I am now committing the attached updated diff.
I have bootchecked it twelve times:

- in hlc.gc, asm_fast.gc and asm_fast.debug.stseg.gc;
- in 64 and 32 bit mode; and
- with the new functionality switched on and off.

In the committed version, the new functionality is switched off by default,
so as not to cause any binary incompatibility. If anyone wants to try out
the new functionality, which I encourage, you need to toggle the default
values of the allow_packing_dummies and allow_packing_ints options
in compiler/options.m. Note that these are effectively grade options
(though temporary ones); you cannot safely link together modules
that were compiled with different values of these options.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.idpack2
Type: application/octet-stream
Size: 434414 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20180505/fce2886e/attachment-0001.obj>


More information about the reviews mailing list