[m-rev.] for post-commit review: group *int_least* types together
Zoltan Somogyi
zoltan.somogyi at runbox.com
Wed Feb 21 15:10:51 AEDT 2018
On Tue, 20 Feb 2018 05:00:55 -0500 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> I suggest making the test for the uint_least32 case something like:
>
> 0 =< N,
> ( int.bits_per_int = 32
> ; int64.from_int(N) < 4294967295_i64
> )
Would the attached diff be ok? It also consistently uses
symmetric checks, [] instead of [), partly for style,
and partly to avoid referring to int32_max + 1.
Zoltan.
More information about the reviews
mailing list