[m-rev.] for review: add builtin 64-bit integer types -- part 2

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Feb 3 00:05:44 AEDT 2018

On Thu, 1 Feb 2018 21:03:12 -0500 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> Have you had an opportunity to look at the library changes
> yet?

Yes, but I forgot :-(

Thanks for reminding me. My review of the library is attached.

As for the test cases, you are right, adding the C code generating
the "guaranteed correct" output in the test cases themselves won't work.

For each Mercury test case, we should have C program that does the same
computations and outputs the same results in the same format,
which we would update in sync with the Mercury test case,
and execute once per update manually to generate the .exp file.
Would that work for you?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: REVIEW.int64_stage2.part2
Type: application/octet-stream
Size: 6584 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20180203/7747e7eb/attachment.obj>

More information about the reviews mailing list