[m-rev.] [m-dev.] Fwd: Re: arg packing of structured values

[Julien Fischer]

Hi Zoltan,

On Thu, 30 Aug 2018, Zoltan Somogyi wrote:

> On Fri, 27 Jul 2018 13:23:26 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
>>> Packing chars is fragile in the possible presence of such extensions.
>>> I have also seen no need; in my experience, bare chars (on their own,
>>> NOT inside strings) inside structures are pretty rare.
>>
>> FWIW, here's some examples from my CSV library:
>>
>>      :- type comments
>>         --->    no_comments
>>         ;       allow_comments(char).
>>
>>      :- type reader_params
>>          --->    reader_params(
>>                      blank_lines     :: blank_lines,
>>                      trailing_fields :: trailing_fields,
>>                      comments        :: comments,
>>                      field_delimiter :: char
>>                 ).
>>
>> Julien.
>
> The attached diff enables the packing of chars, along the lines discussed on m-dev.
> It is for post-commit review and tryout on his CSV library by Julien.

Done, the CSV library passes its test suite.  The diff looks fine.

Julien.