[m-rev.] for review: Don't print value of errno in MR_fatal_error.

Julien Fischer jfischer at opturion.com
Sun Aug 19 15:19:28 AEST 2018


Hi Peter,

On Sun, 19 Aug 2018, Peter Wang wrote:

> The majority of calls to MR_fatal_error do not follow an operation that
> sets errno, so printing out an error message unrelated to the reason for
> the fatal error will lead to confusion. It can also cause test failures
> if errno happens to be set to non-zero some time prior to an expected
> call to MR_fatal_error. Fixes bug #464.

That looks fine.

Julien.


More information about the reviews mailing list