[m-rev.] for review: Fix failing tabled_typeclass test case.

Julien Fischer jfischer at opturion.com
Tue Aug 7 17:43:51 AEST 2018


Hi Peter,

On Tue, 7 Aug 2018, Peter Wang wrote:

> tests/debugger/Mmakefile:
>    Filter memory addresses from the output.
>
> tests/debugger/tabled_typeclass.inp:
>    Print all io actions in two steps: 0-5 for non-debug grades,
>    then 6-29 for debug grades.
>
> tests/debugger/tabled_typeclass.exp:
> tests/debugger/tabled_typeclass.exp2:
>    Update expected outputs.
>
>    Conform to changes to the io module.

That's fine.  (Although, for testing purposes it would be
useful to have a way to tell the debugger to print *all* I/O actions
in order to avoid hardcoding specific numbers as here.)

One more general point: for test cases where there are multiple expected
outputs I think there needs to be more specific documentation about what
each expected output corresponds.  While it can sometimes be found
in the log messsages, occasionally it's a bit opaque.  My suggestion
is that the header comment of each test with multiple expected outputs
should list what they all are.  Opinions?

Julien.


More information about the reviews mailing list