[m-rev.] for review: Use uints to represent bit vectors.

Julien Fischer jfischer at opturion.com
Mon Apr 16 11:12:08 AEST 2018



On Mon, 16 Apr 2018, Peter Wang wrote:

> On Sun, 15 Apr 2018 08:14:26 -0400 (EDT), Julien Fischer <jfischer at opturion.com> wrote:
>>
>> Hi Peter,
>>
>> On Sun, 15 Apr 2018, Julien Fischer wrote:
>>
>>> On Sun, 15 Apr 2018, Peter Wang wrote:
>>>
>>>>  library/fat_sparse_bitset.m
>>>>  library/sparse_bitset.m:
>>>>  library/tree_bitset.m:
>>>>     As above.
>>>
>>> Include the above (i.e. the mail subject) in the log message, othewise
>>> the log will look weird.
>>>
>>>>  ---
>>>>  library/fat_sparse_bitset.m | 109
>>>>  +++++++++++++++++++++++---------------------
>>>>  library/sparse_bitset.m     | 109
>>>>  +++++++++++++++++++++++---------------------
>>>>  library/tree_bitset.m       |  88 ++++++++++++++++++-----------------
>>>>  3 files changed, 157 insertions(+), 149 deletions(-)
>>>
>>> That's fine otherwise.
>>
>> Actually, not so fine in practice as it seems to have broken building
>> stage 2; we now get a sequence of errors of the form:
>>
>
> Damn, I had bootchecked in hlc.gc but not asm_fast.gc.
> The change to output_uint_expr fixes the problem. Thanks.

The csharp grade is also broken.

Mercury/css/sparse_bitset.cs(718,27): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(1454,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(1549,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(5809,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(5951,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(6093,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(6235,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'
Mercury/css/sparse_bitset.cs(6377,20): error CS0031: Constant value
`18446744073709551615' cannot be converted to a `uint'

Julien.


More information about the reviews mailing list