[m-rev.] for review: Use uints to represent bit vectors.

Julien Fischer jfischer at opturion.com
Sun Apr 15 22:14:26 AEST 2018


Hi Peter,

On Sun, 15 Apr 2018, Julien Fischer wrote:

> On Sun, 15 Apr 2018, Peter Wang wrote:
>
>>  library/fat_sparse_bitset.m
>>  library/sparse_bitset.m:
>>  library/tree_bitset.m:
>>     As above.
>
> Include the above (i.e. the mail subject) in the log message, othewise
> the log will look weird.
>
>>  ---
>>  library/fat_sparse_bitset.m | 109
>>  +++++++++++++++++++++++---------------------
>>  library/sparse_bitset.m     | 109
>>  +++++++++++++++++++++++---------------------
>>  library/tree_bitset.m       |  88 ++++++++++++++++++-----------------
>>  3 files changed, 157 insertions(+), 149 deletions(-)
>
> That's fine otherwise.

Actually, not so fine in practice as it seems to have broken building
stage 2; we now get a sequence of errors of the form:

     gmake: *** [bt_array.optdate] Error 1
     /mnt/opturion/mercury/rotd-2018-04-12/bin/mmc
     --make-optimization-interface --grade asm_fast.gc     --mercury-linkage
     shared --flags LIB_FLAGS   --flags INTER_FLAGS     diet
     /mnt/opturion/mercury/rotd-2018-04-12/bin/mmc
     --make-optimization-interface --grade asm_fast.gc     --mercury-linkage
     shared --flags LIB_FLAGS   --flags INTER_FLAGS     digraph
     Uncaught Mercury exception:
     Software Error: map.lookup: key not found
         Key Type: mdbcomp.sym_name.sym_name
         Key Value: qualified(unqualified("string"), "format")
         Value Type: list.one_or_more(parse_tree.modules.import_or_use_context)

Julien.


More information about the reviews mailing list